-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undoing archival of a pinned chat doesn't re-pin it #6968
Comments
I was also looking to see if I could submit a PR myself to fix this. I got as far as finding that clicking Undo triggers this Redux action, where the archived status is restored: Signal-Desktop/ts/state/ducks/conversations.ts Line 1237 in 02e7a9e
Which calls out to the Signal-Desktop/ts/models/conversations.ts Line 4236 in 02e7a9e
But I'm not sure if there's a preferred/good pattern for remembering that status, so it can be restored when undoing, so for now I gave up there. Alternatively, maybe that action shouldn't unpin it in the first place, and the list of pinned chats should just not show archived chats. But I'm weeding into architectural decisions too much for a drive-by PR, so I'll leave t at that - but happy to take another look if so desired, if you have suggestions on where to go next. |
I think for the Undo operation specifically we should also undo the |
Perfect, thanks. PR here: #6969 |
Using a supported version?
Overall summary
When I accidentally archive a chat (because I mix up the keyboard shortcut with that of another app), I can click "Undo" in the toast. But if that chat was pinned, it will no longer be pinned after hitting Undo.
Steps to reproduce
Expected result
The chat to be unarchived, and pinned.
Actual result
The chat is unarchived, but no longer pinned.
Screenshots
No response
Signal version
7.19.0
Operating system
Fedora Silverblue Linux 40 (via Flatpak - apologies for reporting here, but this seems very unlikely to be a packaging issue)
Version of Signal on your phone
7.12.3 (Android)
Link to debug log
No response
The text was updated successfully, but these errors were encountered: