Re-pin a conversation after undoing archival #6969
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
main
branchnpm run ready
run passes successfully (more about tests here) - sort of. It runs the same as onmain
, but tests end with 9 tests pending, and a bunch of alert dialogs about render processes erroring, and some type errors on code I did not touch (e.g.Property 'newUnauthenticatedChatService' does not exist on type 'Net'.
).Description
Fixes #6968 following these pointers. If you archive a pinned conversation, then undo that, with this change, the conversation will be pinned again.
I tested it manually using the standalone setup, on Fedora Silverblue Linux 40. I couldn't find which files would contain tests for the files I touched, but could look at writing some tests with some pointers.