MessageView: Handle change of color to null, call getColor() #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we relied on the actual value of the color property to be supplied to the updateColor change event listener, sometimes it would be null. Then the conversation bubbles would have no color at all, making the text hard to read. FREEBIE
scottnonnenberg
added a commit
that referenced
this pull request
Sep 7, 2017
Fix bug causing contact and group names/colors to be lost (#1437) Fix broken Swedish translation preventing new installs (8caecd5) Fix clear message bubbles when adding contact with previous messages in iOS (#1438) Fix message bubble widths on horizontal resizes (#1447) Remove horizontal scrolling in convo/message lists (#1448) Update translations for hr, pt_BR and sv (8dca9c9) Export (still behind a flag): - Limit attachment filename length for Windows path limits (#1439) - Reintroduce conversation last-contact date in directory name (#1439) Add tests for export utility functions (#1439) FREEBIE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we relied on the actual value of the color property to be supplied to the
updateColor()change event listener, sometimes it would benull. Then the conversation bubbles would have no color at all, making the text hard to read.This happens for iOS users who have been communicating with a phone number, then add a contact for that user. (Because iOS does not supply a color in its contact sync data)