Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

focus() visible window on show-window instead of show() #1455

Merged
merged 1 commit into from
Sep 11, 2017

Conversation

scottnonnenberg
Copy link
Contributor

@scottnonnenberg scottnonnenberg commented Sep 8, 2017

When clicking on a notification in Windows when a window had been stuck to one side of the screen using Snap, the window would be repositioned. We now use a less-aggressive technique for calling attention to ourselves.

Fixes #1429 (thanks for the correction, Lilia)

When clicking on a notification in Windows when a window had been stuck
to one side of the screen using Snap, the window would be repositioned.

Fixes #1453

FREEBIE
@liliakai
Copy link
Contributor

Fixes #1429 ?

@scottnonnenberg scottnonnenberg merged commit 9c4d73f into electron Sep 11, 2017
@scottnonnenberg scottnonnenberg deleted the windows-reposition branch September 11, 2017 16:47
scottnonnenberg added a commit that referenced this pull request Sep 11, 2017
Contact profiles support - display avatars and names (#1453)

Audio notes can now be recorded on Windows (#1456)

When window is snap-positioned on windows, no longer automatically
re-position window (#1455)

Ensure that our sound setting applies for all notification types (#1445)

Fix loading screen hang with application is unlinked (#1440)

Fix error dialog on initial load (#1440)

Based on https://github.com/WhisperSystems/Signal-Desktop/releases/tag/v0.43.3

FREEBIE
scottnonnenberg added a commit that referenced this pull request Sep 15, 2017
When clicking on a notification in Windows when a window had been stuck
to one side of the screen using Snap, the window would be repositioned.

Fixes #1453

FREEBIE
scottnonnenberg added a commit that referenced this pull request Sep 15, 2017
Contact profiles support - display avatars and names (#1453)

Audio notes can now be recorded on Windows (#1456)

When window is snap-positioned on windows, no longer automatically
re-position window (#1455)

Ensure that our sound setting applies for all notification types (#1445)

Fix loading screen hang with application is unlinked (#1440)

Fix error dialog on initial load (#1440)

Based on https://github.com/WhisperSystems/Signal-Desktop/releases/tag/v0.43.3

FREEBIE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants