Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NavSidebar.scss to use z-index from _variables.scss #6638

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lvthanh03
Copy link
Contributor

Previously, NavSidebar used a magic number for z-index. This commit changed this z-index to use $z-index-above-base from _variables.scss.

Fixes #6633 where contextmenu--visible (part of ConversationPanel) is hidden behind NavSidebar.

First time contributor checklist:

Contributor checklist:

  • My contribution is not related to translations.
  • My commits are in nice logical chunks with good commit messages
  • My changes are rebased on the latest main branch
  • A yarn ready run passes successfully (more about tests here)
  • My changes are ready to be shipped to users

Description

Fixes #6633, where menu is hidden behind NavSidebar.

Previously, NavSidebar used a magic number for z-index.

This commit changed this z-index to use $z-index-above-base from _variables.scss.

Previously, NavSidebar used a magic number for z-index. This commit changed this z-index to use  $z-index-above-base from _variables.scss.

Fixes signalapp#6633 where contextmenu--visible (part of ConversationPanel) is hidden behind NavSidebar.
@lvthanh03
Copy link
Contributor Author

Thanks for taking your time to review this PR, @josh-signal!

@scottnonnenberg-signal
Copy link
Contributor

Is this change still needed? We believe that we fixed the underlying issue here: 0f6d82d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Conversation menu shows behind conversation list
4 participants