Fix: Contact avatar not aligned correctly in LeftPane - narrow + scrollbar #6755
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
main
branchyarn ready
run passes successfully (more about tests here)Description
Fixes incorrect alignment of profile avatar in left pane when in narrow mode and with scroll bar visible (conversations do not fit into the screen height).
Before:
![Signal-before](https://private-user-images.githubusercontent.com/79979498/298279740-16fb10ee-6498-4ad1-aa60-2e1d98eac958.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwOTcwMDksIm5iZiI6MTcyNjA5NjcwOSwicGF0aCI6Ii83OTk3OTQ5OC8yOTgyNzk3NDAtMTZmYjEwZWUtNjQ5OC00YWQxLWFhNjAtMmUxZDk4ZWFjOTU4LmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTExVDIzMTgyOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZlNTgyYmIzNWIzMDhlZmFiNTM5NWIwYjA4N2M3ODk1ZTdmNzIxYTdjMTg2YTIxNDg5NGE5YjFiOTYzNGEzYjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.40QrhuZTMYsmVeSXOE6lhvJ3G0RSvXc5W7dadnkUlzg)
(notice the highlighted conversation with profile avatar in the left pane)
After:
![Signal-after-without](https://private-user-images.githubusercontent.com/79979498/298280060-6c399ee0-a3f3-4ccc-a568-f5fd5d86da44.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwOTcwMDksIm5iZiI6MTcyNjA5NjcwOSwicGF0aCI6Ii83OTk3OTQ5OC8yOTgyODAwNjAtNmMzOTllZTAtYTNmMy00Y2NjLWE1NjgtZjVmZDVkODZkYTQ0LmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTExVDIzMTgyOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQwMGQ4YWZjNzk2NzExN2Y2MmI0YWViZTg3NmM3M2I4OTk4ZGU0ZThhMGNlMDQ5MDBhMGJkY2FlZDE5MDFkY2YmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.6gKKvoUdcxRv7IZQouzfmvHX3K0_oALWMVii340TcHE)
After with scrollbar visible:
![Signal-after-with](https://private-user-images.githubusercontent.com/79979498/298280072-7d23a6e8-8c2f-4522-8ee3-e523b9ccf436.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwOTcwMDksIm5iZiI6MTcyNjA5NjcwOSwicGF0aCI6Ii83OTk3OTQ5OC8yOTgyODAwNzItN2QyM2E2ZTgtOGMyZi00NTIyLThlZTMtZTUyM2I5Y2NmNDM2LmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTExVDIzMTgyOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM4MzM2ZjdkMzM4ZjFkNmM2YjhmZTdkNWY5NDZhNzM2NTAxOWZiOTVlMjI2ZmZiMDdkOGU5YWI1ZmU4YTQ5N2UmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.rEb5APUZ37UF0AxG1GdOoehoAA-oQ_m1dPiAQc4CqhU)
After the change, the items in the left pane are aligned the same way as they are while in widened mode of the left pane = there is more space on the right side from the list item to accommodate the scrollbar.
This issue appears only when there is enough conversations open in the left pane to overflow the window's view height.