Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mac-screen-capture-permissions #6936

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dashkb
Copy link

@dashkb dashkb commented Jul 9, 2024

First time contributor checklist:

Contributor checklist:

  • My contribution is not related to translations.
  • My commits are in nice logical chunks with good commit messages
  • My changes are rebased on the latest main branch
  • A npm run ready run passes successfully (more about tests here)
  • My changes are ready to be shipped to users

Description

Following the instructions in the Contributor Guidelines I encountered the (common?) issue building mac-screen-capture-permissions. Upgrading it to 2.1.0 silences the message and eliminates a few dependencies.

I see in #6889 that the issue can be ignored, but wonder if this might be better. I'm new so maybe there's a reason to prefer ignoring the warning to upgrading the dependency.

Fixes #6063

@jamiebuilds-signal jamiebuilds-signal self-assigned this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Build failure on aarch64 (M1 Macbook)
2 participants