Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX, #6659] bug/editing-a-sent-message-deletes-draft-of-new-message #6946

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[FIX, #6659] bug/editing-a-sent-message-deletes-draft-of-new-message #6946

wants to merge 3 commits into from

Conversation

ben-biddington
Copy link
Contributor

@ben-biddington ben-biddington commented Jul 23, 2024 •
edited
Loading

See: #6659

Contributor checklist:

  • My contribution is not related to translations.
  • My commits are in nice logical chunks with good commit messages
  • My changes are rebased on the latest main branch
  • A npm run ready run passes successfully (more about tests here)
  • My changes are ready to be shipped to users

Description

This resolves the behaviour described in #6659 👍

@trevor-signal
Copy link
Contributor

@ben-biddington thanks for raising this, and I appreciate the effort & patterns you've introduced in this test. Our plan to address this issue is to prevent editing a message while a draft is in progress.

@trevor-signal trevor-signal self-assigned this Jul 23, 2024
ben-biddington
ben-biddington commented Jul 23, 2024
View reviewed changes
ts/state/selectors/message.ts
Copy link
Contributor Author

@ben-biddington ben-biddington Jul 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change okay? It's the simplest and first thing I tried.

@ben-biddington
Copy link
Contributor Author

Okay latest has moved and renamed Screen and added a passing test.

Test is flaky so still looking at it

@ben-biddington ben-biddington marked this pull request as draft July 23, 2024 22:32
@ben-biddington
Copy link
Contributor Author

Added sleeps to the flaky test in order to allow the menu to re-render, open to suggestions for a better thing to wait for

@ben-biddington ben-biddington marked this pull request as ready for review July 24, 2024 19:32
@ben-biddington ben-biddington changed the title [FIX, HELP-WANTED, #6659] Add reproduction of reported behaviour [FIX, #6659] Add reproduction of reported behaviour Jul 29, 2024
@ben-biddington ben-biddington changed the title [FIX, #6659] Add reproduction of reported behaviour [FIX, #6659] Editing a sent message deletes draft of new message Jul 29, 2024
@ben-biddington ben-biddington changed the title [FIX, #6659] Editing a sent message deletes draft of new message [FIX, #6659] bug/editing-a-sent-message-deletes-draft-of-new-message Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@trevor-signal trevor-signal

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ben-biddington @trevor-signal