[FIX, #6928] bug/transparent-png-does-not-work-#6928 #6947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-biddington
changed the title
ben-biddington
force-pushed
the
bug/transparent-png-does-not-work-#6928
branch
from
c4e540d
to
c43cc86
Compare
ben-biddington
changed the title
ben-biddington
force-pushed
the
bug/transparent-png-does-not-work-#6928
branch
from
f836da2
to
64440e7
Compare
[signalapp#6928] Transparent Png Doesn't Work (Even With Files) Add a failing test to show that in some cases uploading a png file results in a jpg being produced. [signalapp#6881] File size increase when sending images Add a passing test that automates the example written in the issue, where a file's size increases after uploading. Run with: npm run generate && npm run test-electron -- --grep="image processing" It does add an extra devDependency, hope that's okay. It's for inspecting jpeg images.
This does make the test pass, not sure if there are wider implications. Is there a reason png files need to be converted to jpeg sometimes?
ben-biddington
force-pushed
the
bug/transparent-png-does-not-work-#6928
branch
from
dd1805f
to
562d35e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist:
mainbranchnpm run readyrun passes successfully (more about tests here)Run these new tests with:
Fix
All I have done is modify
ts/util/scaleImageToLevel.tsto preserve file type instead of hard-wiring to jpeg and the test passes.Not sure of other implications or possible reasons for changing png to jpg that I may have missed.
Before
Transparent pngs are re-rencoded as jpg and their backgrounds are black.
After
[6881] File size increase when sending images
While doing that I wondered about #6881 as well so added a characterizsation test for that which demonstrates the reported behaviour.
Not a fix just something to make pass.