-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to select all media in selection mode #5685
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my code clean-up suggestion :)
Approved 👍
Signal/src/ViewControllers/MediaGallery/MediaGalleryAccessoriesHelper.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: pawisoon <pawi552@gmail.com>
I hope that this welcome feature is added in short notice, since a lot of users are struggling with cleansing their media in Signal! |
Please merge this asap, a lot of people needs this |
Belated happy new year to the Signal team 😚🎉 How are we looking at getting this in? |
@harry-signal please please please can we get this merged? It's so frustratingly difficult and time consuming to manage storage space in Signal on iOS and this will be such a huge help for such a small change. |
+1 hoping for this to come asap |
I am absolutely begging you to get this in please! @harry-signal ... anyone? Just let me know what I can do to move this simple but incredibly useful change forward. Thanks. |
I know devs are working on other backup functionality, but this is a fucking joke. They just need to push this and a lot of people would have easier lifes |
First time contributor checklist
Contributor checklist
Description
When deleting media it can take an extraordinary amount of time to select all items to delete as there is currently no way to select all. This is not only inconvenient but impacts user security when it may be necessary to delete all media from a conversation quickly without losing the text of the conversation. It's also a very common UI pattern to be able to select all items.
This PR adds a text button to the task bar allowing the user in one tap to select all the items in the view. When any items are selected the text of the buttons allows the user to select none.
The button is placed on the left away from the Delete button to prevent any accidental presses.
Screen.Recording.2023-10-16.at.23.13.24.mov