Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ignore 'shouldAutoPlayVideo' function parameter in MediaPageViewController. #5789

Closed
wants to merge 1 commit into from

Conversation

alex1704
Copy link

@alex1704 alex1704 commented Apr 9, 2024

Contributor checklist

  • My commits are rebased on the latest main branch
  • My commits are in nice logical chunks
  • My contribution is fully baked and is ready to be merged as is
  • I have tested my contribution on these devices:
  • iPhone 7, iOS 15.7.9

Description

Currently when MediaPageViewController.setCurrentItem is invoked shouldAutoPlayVideo parameter is ignored and MediaItemViewController.shouldAutoPlayVideo property is always set to true inside function.
In this PR I changed only part related to behaviour in MediaPageViewController.setCurrentItem but MediaPageViewController have several calls to setCurrentItem where this parameter is not used explicitly and its default to false which may alter desired final behaviour as currently MediaItemViewController.shouldAutoPlayVideo is always true. I would gladly change all places where setCurrentItem but I do not know specs.

Copy link

stale bot commented Jul 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 9, 2024
Copy link

stale bot commented Jul 17, 2024

This issue has been closed due to inactivity.

@stale stale bot closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

1 participant