Build linux binaries with docker buildx
#13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-signal
force-pushed
the
jon/docker_buildx
branch
from
2d3f76d to
ae9002d
Compare
gram-signal
approved these changes
Jun 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As near as I can tell,
docker builddoes not support and never has supported a--platformflag. This changes the build process to usedocker buildx, which does allow us to build platform-specific images (in my case, via QEMU). The change in build process does result in changing some binary names to match the architecture strings we're passing to Docker, but that should all be hidden from end users.