signal-neon-futures: Only run Rust futures on an existing EventQueue #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node can more efficiently handle multiple tasks coming in on the same queue, so remove the "convenience" APIs that derive a new queue from a Context, and require an existing EventQueue instead. This cuts more time off of our decryption benchmark (not checked in). Additionally, run the first poll for the future synchronously, to avoid having to wait for the event loop to pick up the task to start the future.
jim-signal
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node can more efficiently handle multiple tasks coming in on the same queue*, so remove the "convenience" APIs that derive a new queue from a Context, and require an existing EventQueue instead. This cuts more time off of our decryption benchmark (not checked in).
Additionally, run the first poll for the future synchronously, to avoid having to wait for the event loop to pick up the task to start the future.
* or will be able to when nodejs/node#38506 is released