Stumpf haproxy #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 12, 2017 10:58
…port to get stats through tcp.
mstumpfx
requested review from
keitwb,
mjtieman,
molner,
asuresh4 and
codesmith14
mstumpfx
commented
Sep 13, 2017
haproxy.py
Outdated
| DIMENSIONS_LIST = [ | ||
| 'pxname', | ||
| 'svname', | ||
| 'weight', |
There was a problem hiding this comment.
Don't send weight as dim unless it will remain constant always.
mstumpfx
commented
Sep 13, 2017
haproxy.py
Outdated
| proxy_monitors = [] | ||
| excluded_metrics = set() | ||
| enhanced_metrics = False | ||
| interval = DEFAULT_INTERVAL |
added 2 commits
September 13, 2017 11:48
…ult interval, still allow for interval to be set
|
LGTM after your recent changes. There's quite a few other reviewers on here so I'll hold off on the merge for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Productize HAProxy plugin, added new metrics and filtering. Added support to get stats through tcp.