Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Add SAP Hana monitor #1963

Merged
merged 15 commits into from
Nov 1, 2021
Merged

Add SAP Hana monitor #1963

merged 15 commits into from
Nov 1, 2021

Conversation

pmcollins
Copy link
Contributor

This monitor was written by the CK team, then modified and tested against an SAP Hana cloud instance.

Copy link
Contributor

@keitwb keitwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A bit late to the game but ok.

@keitwb
Copy link
Contributor

keitwb commented Oct 21, 2021

You need to fix up all all the build failures though.

@pmcollins pmcollins marked this pull request as ready for review October 22, 2021 21:10
@pmcollins
Copy link
Contributor Author

@rmfitzpatrick, @mstumpfx all good?

Copy link
Contributor

@mstumpfx mstumpfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmcollins pmcollins merged commit 7ff6256 into main Nov 1, 2021
@atoulme atoulme deleted the sap_hana branch November 10, 2022 20:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants