This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
sap hana: update metric metadata #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmcollins
requested review from
asuresh4,
jeffreyc-splunk,
keitwb,
mstumpfx,
rmfitzpatrick and
a team
as code owners
|
Should all of these be default? It looks like only 4 aren't:
If there's likely only one hana service being monitored at a time then I guess it may not matter though. |
rmfitzpatrick
approved these changes
Nov 4, 2021
mstumpfx
approved these changes
Nov 4, 2021
pmcollins
force-pushed
the
hana-metadata
branch
2 times, most recently
from
bfa645a to
d4187a2
Compare
|
Looks like there are just two metrics that aren't in the dashboard json: sap.hana.statement.active.execution.memory.sum (I wrote a script that updates the meta yaml based on the dashboard json, and it works, but I appear to have messed up getting those results into this PR somehow 🤦 . Anyway I've marked them as default: false and pushed that change.) |
pmcollins
force-pushed
the
hana-metadata
branch
from
d4187a2 to
27657be
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After doing some testing, found that some metrics were missing from metadata and some were mistakenly marked
default: false.