This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Better logging for aws metadata #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dani Louca <dlouca@splunk.com>
dloucasfx
requested review from
asuresh4,
jeffreyc-splunk,
keitwb,
mstumpfx,
rmfitzpatrick and
a team
as code owners
asuresh4
reviewed
Nov 4, 2021
asuresh4
approved these changes
Nov 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the logging in this change was undone when we converted to use SDK
In this PR, I opted not to use
Available()as this func does not return the actual error , which is needed for debugging.Signed-off-by: Dani Louca dlouca@splunk.com