Force apache commons-codec to 1.15 #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
approved these changes
Jul 1, 2022
laurit
reviewed
Jul 1, 2022
| <!-- Temp work-around until httpclient upgrades its codec version --> | ||
| <groupId>commons-codec</groupId> | ||
| <artifactId>commons-codec</artifactId> | ||
| <version>1.15</version> |
There was a problem hiding this comment.
you don't need to add the version number here, having it in the parent pom is enough. None of the other dependencies in this file add a version number. Another option is to not add this dependency here at all, having it in parent is sufficient.
laurit
reviewed
Jul 1, 2022
| @@ -155,6 +155,12 @@ | |||
| <artifactId>commons-io</artifactId> | |||
| <version>2.11.0</version> | |||
| </dependency> | |||
| <dependency> | |||
| <!-- Temp work-around until httpclient upgrades its codec version --> | |||
There was a problem hiding this comment.
this comment is a bit misleading. last release from 4.5.x series of http client was in 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigates https://security.snyk.io/vuln/SNYK-JAVA-COMMONSCODEC-561518
It sucks to do it this way, but it looks like the v4.x release of httpclient hasn't yet been updated (see the bottom comment from 6 months ago) https://issues.apache.org/jira/browse/HTTPCLIENT-2072