add support for always on profiling to zero config #2538
Conversation
-Dsplunk.profiler.enabled=true -Dsplunk.profiler.memory.enabled=true -Dsplunk.metrics.enabled=true These are turned off by default, so existing users will not be affected at this time.
instrumentation/README.md
Outdated
| ### generate_service_name (optional) | ||
|
|
||
| Set this value to `false` to prevent the preloader from setting the `OTEL_SERVICE_NAME` environment variable. | ||
| Default: `true`. |
There was a problem hiding this comment.
Is there a doc or brief description you could provide of what the false behavior is?
There was a problem hiding this comment.
Which takes precedence if both generate_service_name is true and service_name is set?
There was a problem hiding this comment.
Turns out there really isn't a doc yet that describes in detail what the instrumentation library does, although there is this. But I've added a couple of sentences to explain the implications of the false behavior.
Regarding precedence, generate_service_name=true will cause the .so generate the service name either dynamically or via the service_name override. If it's false, no service name will be set, regardless of the value of the service_name override. I've added an explanation to the readme as well as a test case.
This change adds three new configuration parameters that individually turn on the following flags:
-Dsplunk.profiler.enabled=true
-Dsplunk.profiler.memory.enabled=true
-Dsplunk.metrics.enabled=true
These are turned off by default, so existing users will not be affected at this time.