[receiver/discovery] Do not emit endpoint that are not evaluated yet #5032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
dont-emit-not-evaluated-endpoints
branch
from
2b406f2
to
d320a3d
Compare
crobert-1
reviewed
Jun 27, 2024
dmitryax
force-pushed
the
dont-emit-not-evaluated-endpoints
branch
from
d320a3d
to
23dc993
Compare
Added |
crobert-1
reviewed
Jun 27, 2024
This change fixes the issue when "unknown" service can be shown in the inventory service right at the collector startup. We don't want to send entity events for endpoints that are not evaluated yet
dmitryax
force-pushed
the
dont-emit-not-evaluated-endpoints
branch
from
23dc993
to
6306099
Compare
|
Sure. Updated |
crobert-1
approved these changes
Jun 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the issue when "unknown" service can be shown in the inventory service right at the collector startup. We don't want to send entity events for endpoints that are not evaluated yet