Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add headerssetterextension #5276

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

asreehari-splunk
Copy link
Contributor

Description: Adding the headersettersextension

@asreehari-splunk asreehari-splunk requested review from a team as code owners August 22, 2024 17:35
CHANGELOG.md Outdated Show resolved Hide resolved
docs/components.md Outdated Show resolved Hide resolved
internal/components/components.go Outdated Show resolved Hide resolved
internal/components/components_test.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 nit suggestions, other than that LGTM.

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
docs/components.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
docs/components.md Outdated Show resolved Hide resolved
@asreehari-splunk asreehari-splunk force-pushed the AddHeadersSetterExtension branch 4 times, most recently from 4f55bb4 to df8febf Compare August 26, 2024 18:56
@@ -4,12 +4,15 @@

### 🚀 New components 🚀


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

- (Splunk) Add `nginx` receiver ([5229](https://github.com/signalfx/splunk-otel-collector/pull/5229))

### 💡 Enhancements 💡

- (Splunk) Update JMX Metric Gatherer to [v1.37.0](https://github.com/open-telemetry/opentelemetry-java-contrib/releases/tag/v1.37.0) ([#5240](https://github.com/signalfx/splunk-otel-collector/pull/5240))


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@atoulme atoulme merged commit a78d2a0 into signalfx:main Aug 26, 2024
238 of 241 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants