-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: add converter to update batch processor #5387
Draft: add converter to update batch processor #5387
Conversation
1e66b6a
to
fd1749a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:LGTM, I would like someone to look at the sapm configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the default config file agent_config.yaml
as well
internal/configconverter/update_batchproc_on_token_passthrough.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit & personal preference: instead of _w_
and _wo_
on the test files I would rather use _with_
and _no_
, up to you.
internal/configconverter/update_batchproc_on_token_passthrough.go
Outdated
Show resolved
Hide resolved
0c95517
to
31e0bf6
Compare
internal/configconverter/update_batchproc_on_token_passthrough.go
Outdated
Show resolved
Hide resolved
31e0bf6
to
6320ef3
Compare
internal/configconverter/update_batchproc_on_token_passthrough.go
Outdated
Show resolved
Hide resolved
when sapm exporter enables token_access_passthrough use this converter to add include_metadata with the right header key
6320ef3
to
6f85316
Compare
closing in favor of #5408 after benchmarking the batch processor |
closing |
when sapm exporter enables token_access_passthrough use this converter to add include_metadata with the right header key
Description:
Link to Splunk idea: <Link to Splunk idea, see https://ideas.splunk.com>
Testing:
Documentation: