Use pdata for prometheus monitor #5545
Merged
+103
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
use_pdata_prometheus
branch
3 times, most recently
from
4eb0309
to
7cc3c74
Compare
atoulme
force-pushed
the
use_pdata_prometheus
branch
from
7cc3c74
to
6b0d302
Compare
dmitryax
reviewed
Oct 24, 2024
Comment on lines
+141
to
+149
| metric := pmetric.NewMetric() | ||
| metric.SetName(name + "_count") | ||
| sum := metric.SetEmptySum() | ||
| sum.SetIsMonotonic(true) | ||
| sum.SetAggregationTemporality(pmetric.AggregationTemporalityCumulative) | ||
| dp := sum.DataPoints().AppendEmpty() | ||
| dp.SetIntValue(int64(h.GetSampleCount())) //nolint:gosec // disable G115 | ||
| _ = dp.Attributes().FromRaw(dims) | ||
| dps = append(dps, metric) |
There was a problem hiding this comment.
So, we are creating one metric with one data point for each Prometheus time series. Is that correct? I don't see any combining logic down the road...
There was a problem hiding this comment.
Looks like the existing sfxDatapointsToPDataMetrics implementation does pretty much the same though...
There was a problem hiding this comment.
Yes, this is a simple follow through to make sure we get the same behavior for now.
|
Do we have any tests to confirm that the output hasn't changed? |
dmitryax
approved these changes
Oct 24, 2024
|
Yes, we have multiple tests that check with golden files that the prometheus metrics match. Both for simple gauges and counters and histograms. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.