Smoke test for the Oracle WebLogic #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to create needed images for testing.
iNikem
reviewed
Nov 3, 2020
smoke-tests/src/test/java/com/splunk/opentelemetry/SpringBootSmokeTest.java
Outdated
Show resolved
Hide resolved
smoke-tests/src/test/java/com/splunk/opentelemetry/WebLogicSmokeTest.java
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,50 @@ | |||
| import os | |||
There was a problem hiding this comment.
All these files in this directory, where are they from? Who is the original author and what is their license?
There was a problem hiding this comment.
I wrote them based on examples in https://github.com/oracle/docker-images/tree/master/OracleWebLogic/dockerfiles/12.2.1.4/container-scripts and other relevant subprojects.
smoke-tests/src/test/java/com/splunk/opentelemetry/SmokeTest.java
Outdated
Show resolved
Hide resolved
iNikem
reviewed
Nov 3, 2020
smoke-tests/src/test/java/com/splunk/opentelemetry/SpringBootSmokeTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
|
Spring boot smoke tests are currently failing because of this: open-telemetry/opentelemetry-java-instrumentation#1546 |
* add configuration changes to migration * correct config changes Co-authored-by: Nikita Salnikov-Tarnovski <nsalnikovtarnovski@splunk.com>
…k for trace in headers.
# Conflicts: # custom/src/main/java/com/splunk/opentelemetry/InstrumentationLibrarySpanProcessor.java # custom/src/test/java/com/splunk/opentelemetry/InstrumentationLibrarySpanProcessorTest.java # smoke-tests/src/test/java/com/splunk/opentelemetry/SpringBootSmokeTest.java
iNikem
approved these changes
Nov 11, 2020
smoke-tests/src/test/java/com/splunk/opentelemetry/SmokeTest.java
Outdated
Show resolved
Hide resolved
smoke-tests/src/test/java/com/splunk/opentelemetry/WebLogicSmokeTest.java
Outdated
Show resolved
Hide resolved
smoke-tests/src/test/java/com/splunk/opentelemetry/SmokeTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smoke test is built using same concepts as existing smoke tests in this repo and in
opentelemetry-java-instrumentation. It covers officially supported WebLogic versions - WLS 12 on Java 8 and WLS 14 on Java 8 and 11.Because of yet unclear (work in progress) legal arrangements for building and publishing shared images with WebLogic (which could be used in GitHub actions and environments alike), test is expecting local WebLogic images. If there are no images, then test is ignored. To build local development images of Oracle WebLogic one has to follow the instructions in
src/weblogic/README.mdand download some files from Oracle, while agreeing to its development license terms.Because the smoke test for WLS has one more dimension in addition to just
jdk,SmokeTestandSpringBootTestwere updated to provide a supplier function for the image name lookup instead of an abstract method takingjdkas an input argument. This part sort of redoes PR #25 while solving the issue #20