Phase1 jetty linux #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iNikem
reviewed
Nov 26, 2020
.../src/main/java/com/splunk/opentelemetry/middleware/JettyAttributesInstrumentationModule.java
Show resolved
Hide resolved
.../src/main/java/com/splunk/opentelemetry/middleware/JettyAttributesInstrumentationModule.java
Outdated
Show resolved
Hide resolved
...ation/middleware/src/main/java/com/splunk/opentelemetry/middleware/MiddlewareAttributes.java
Outdated
Show resolved
Hide resolved
.../main/java/com/splunk/opentelemetry/middleware/MiddlewareBootstrapClassloaderCustomizer.java
Outdated
Show resolved
Hide resolved
matrix/src/main/java/com/splunk/opentelemetry/appservers/javaee/GreetingServlet.java
Outdated
Show resolved
Hide resolved
shared/src/main/java/com/splunk/opentelemetry/javaagent/shared/MiddlewareHolder.java
Outdated
Show resolved
Hide resolved
smoke-tests/src/test/java/com/splunk/opentelemetry/AppServerTest.java
Outdated
Show resolved
Hide resolved
smoke-tests/src/test/java/com/splunk/opentelemetry/AppServerTest.java
Outdated
Show resolved
Hide resolved
shared/src/main/java/com/splunk/opentelemetry/javaagent/shared/MiddlewareHolder.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/splunk/opentelemetry/middleware/JettyAttributesInstrumentationModule.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/splunk/opentelemetry/middleware/JettyAttributesInstrumentationModule.java
Show resolved
Hide resolved
.../main/java/com/splunk/opentelemetry/middleware/MiddlewareBootstrapClassloaderCustomizer.java
Outdated
Show resolved
Hide resolved
matrix/src/main/java/com/splunk/opentelemetry/appservers/javaee/HeaderDumpingServlet.java
Outdated
Show resolved
Hide resolved
smoke-tests/src/test/java/com/splunk/opentelemetry/JettySmokeTest.java
Outdated
Show resolved
Hide resolved
smoke-tests/src/test/java/com/splunk/opentelemetry/JettySmokeTest.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Nov 27, 2020
mateuszrzeszutek
approved these changes
Nov 27, 2020
iNikem
requested changes
Nov 27, 2020
custom/src/main/java/com/splunk/opentelemetry/middleware/MiddlewareAttributeSpanProcessor.java
Show resolved
Hide resolved
iNikem
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the linux part of phase 1 java app servers jetty support. It includes
Middleware attribute collection introduces new
sharedmodule which is configured to be loaded into bootstrap classloader, so that instrumentations may populate middleware attributes inMiddlewareHolderand span processor will add middleware attributes from there.I also replaced kotlin-based build scripts in agent and all new submodules have groovy based build scripts. The reason here is that after discussion with @iNikem we decided, that it would make sense to have the same scripts as o11y other projects.