Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix allocation metric #864

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

laurit
Copy link
Collaborator

@laurit laurit commented Aug 3, 2022

No description provided.

@laurit laurit requested review from a team as code owners August 3, 2022 20:15
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce the zero-value metric, and initially I thought this change failed to fix it for me...but I had left the field instead of moving it to the local variable. Moving it to a local var does indeed seem to fix things. 🤘🏻

@breedx-splk breedx-splk merged commit e77a933 into signalfx:main Aug 3, 2022
@laurit
Copy link
Collaborator Author

laurit commented Aug 4, 2022

I was able to reproduce the zero-value metric, and initially I thought this change failed to fix it for me...but I had left the field instead of moving it to the local variable. Moving it to a local var does indeed seem to fix things. 🤘🏻

It should not make any difference whether it is a field or a local variable, the important part is avoiding it getting gcd.

@laurit laurit deleted the fix-micrometer-allocation-metric branch August 4, 2022 10:12
breedx-splk pushed a commit to breedx-splk/splunk-otel-java that referenced this pull request Aug 11, 2022
* Fix allocation metric

* convert field to local variable
breedx-splk added a commit that referenced this pull request Aug 11, 2022
* Fix allocation metric (#864)

* Fix allocation metric

* convert field to local variable

* prepare for v1.14.2 patch release

* update changelog

Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants