MEDIUM: api: add support for custom response code redirects #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for performing 301 and 302 redirects to a defined url using custom response codes. It also updates the tests for the default blocking code as it now supports changing the default from 406 to 301,302, or 400-599.
daniel-corbett
added a commit
to daniel-corbett/terraform-provider-sigsci
that referenced
this pull request
Apr 6, 2023
This commit allows updating the default WAF blocking code. It supports blocking using 301 or 302 with a custom URL as well as 400-599. It also extends support for the existing site rule blocking codes to allow for the same response codes. This commit requires the merge of signalsciences/go-sigsci#53
shawnps
approved these changes
Apr 10, 2023
daniel-corbett
added a commit
to signalsciences/terraform-provider-sigsci
that referenced
this pull request
Apr 10, 2023
This commit allows updating the default WAF blocking code. It supports blocking using 301 or 302 with a custom URL as well as 400-599. It also extends support for the existing site rule blocking codes to allow for the same response codes. This commit requires the merge of signalsciences/go-sigsci#53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for performing 301 and 302 redirects to a defined url using custom response codes.
It also updates the tests for the default blocking code as it now supports changing the default from 406 to 301,302, or 400-599.