-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge service retries #55
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logging needs to be cleaned up
Created new function `sc.doRequestDetailed` to return the response object and err. Needs some cleanup of the comments.
shawnps
reviewed
Jun 27, 2023
Co-authored-by: shawnps <shawnps@fastly.com>
@mattg-sigsci @shawnps Please let me know what I can do to help move this PR forward. Thank you for the help on this. |
mattg-sigsci
previously approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending resolution of the conversation in Slack.
…Look for Retry-After response header on 404 responses before restarting
… this specific call
shawnps
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention of this PR is to make the function CreateOrUpdateEdgeDeploymentService() more resilient by adding a limited number of retries. This way if the edge service is not ready yet, requests will continue to be made until successful or the maximum number of statically defined number of retries is exceeded.
The function doRequestDetailed() was also added to provide access to the entire response object, which includes the response status, headers, and body. The response status is useful to various case switches to break out of the retry logic.
I have done 2 tests which both involve attempting to create and link and NGWAF edge service to a VCL service.
No modificaitons were made to the VCL as expected.
The expected modificaitons were made to the VCL with the edge inspector linked.
Please let me know if there are other tests that would provide better coverage.