change the room joined position

signalwire · Jan 20, 2025 · 834c78c · 834c78c
1 parent aea4f99
commit 834c78c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/internal/e2e-js/tests/roomSessionDemotePromote.spec.ts b/internal/e2e-js/tests/roomSessionDemotePromote.spec.ts
@@ -137,7 +137,11 @@ test.describe('RoomSession demote participant and then promote again', () => {
 
     await pageTwo.waitForTimeout(1000)
 
-    // --------------- Promote audience from pageOne and resolve on `member.joined` ---------------
+    // --------------- Promote audience from pageOne and resolve on `member.joined` and `room.joined` ---------------
+    const promisePromotedRoomJoined = expectRoomJoined(pageTwo, {
+      invokeJoin: false,
+    })
+
     const promiseMemberWaitingForMemberJoin = pageOne.evaluate(
       async ({ promoteMemberId }) => {
         // @ts-expect-error
@@ -170,10 +174,6 @@ test.describe('RoomSession demote participant and then promote again', () => {
       { promoteMemberId: participant2Id }
     )
 
-    const promisePromotedRoomJoined = expectRoomJoined(pageTwo, {
-      invokeJoin: false,
-    })
-
     await Promise.all([
       promiseMemberWaitingForMemberJoin,
       promisePromotedRoomJoined,

diff --git a/internal/e2e-js/tests/roomSessionDemoteReattachPromote.spec.ts b/internal/e2e-js/tests/roomSessionDemoteReattachPromote.spec.ts
@@ -170,6 +170,10 @@ test.describe('RoomSession demote participant, reattach and then promote again',
 
     // --------------- Time to promote again at PageTwo ---------------
 
+    const promisePromotedRoomJoined = expectRoomJoined(pageTwo, {
+      invokeJoin: false,
+    })
+
     const promiseMemberWaitingForMemberJoin = pageOne.evaluate(
       async ({ promoteMemberId }) => {
         // @ts-expect-error
@@ -202,10 +206,6 @@ test.describe('RoomSession demote participant, reattach and then promote again',
       { promoteMemberId: participant2Id }
     )
 
-    const promisePromotedRoomJoined = expectRoomJoined(pageTwo, {
-      invokeJoin: false,
-    })
-
     await Promise.all([
       promiseMemberWaitingForMemberJoin,
       promisePromotedRoomJoined,