Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a dtmf function for Video RoomSession object #909

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Expose a dtmf function for Video RoomSession object #909

merged 2 commits into from
Nov 16, 2023

Conversation

iAmmar7
Copy link
Collaborator

@iAmmar7 iAmmar7 commented Nov 13, 2023

Description

dtmf function for browser-based Video SDK.

ref: https://github.com/signalwire/cloud-product/issues/8568

Type of change

  • Internal refactoring
  • Bug fix (bugfix - non-breaking)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Code snippets

await roomSession.sendDigits('1');

Copy link

changeset-bot bot commented Nov 13, 2023

🦋 Changeset detected

Latest commit: fd455c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@signalwire/webrtc Minor
@signalwire/core Minor
@signalwire/js Patch
@signalwire/realtime-api Patch
@signalwire/web-api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iAmmar7 iAmmar7 changed the title Expose a function for Video RoomSession object Expose a dtmf function for Video RoomSession object Nov 13, 2023
@iAmmar7 iAmmar7 requested review from jpsantosbh and giavac November 14, 2023 13:42
@giavac
Copy link
Collaborator

giavac commented Nov 14, 2023

Just asking: do we want to use dtmf or sendDigit?
I find sendDigit clearer to understand for developers not familiar with this terminology.

@iAmmar7
Copy link
Collaborator Author

iAmmar7 commented Nov 14, 2023

Just asking: do we want to use dtmf or sendDigit? I find sendDigit clearer to understand for developers not familiar with this terminology.

I agree.

@danieleds does that sound okay to you?

@danieleds
Copy link
Contributor

yes, let's go with sendDigits

@iAmmar7 iAmmar7 merged commit 4ee7b6f into main Nov 16, 2023
@iAmmar7 iAmmar7 deleted the aa/dtmf branch November 16, 2023 11:37
@iAmmar7 iAmmar7 mentioned this pull request Nov 23, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants