Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup & publish package ci #2

Merged
merged 11 commits into from
Sep 7, 2022
Merged

setup & publish package ci #2

merged 11 commits into from
Sep 7, 2022

Conversation

guilherme1805
Copy link
Member

No description provided.

@tofran
Copy link
Member

tofran commented Sep 6, 2022

setup.py

  • Make sure your setup.py has the expected entrypoints so plugin discovery works. More info in the docs;

setup.cfg

  • In the setup.cfg do we need so many ignores? Is this following the Saleor practices? If so write a comment there. Why do some ignores have space and comma , and others just comma , ;
  • pycodestyle is configured for a dir that is not in this repo. Is this a copy-pasta bug?

CI/CD

  • The actions workflopw should validate pep8, flake8, mypy before publishing the package;
  • Keep the yaml native without JSON like code ex: types: [main]. To keep it consistent across our repos.
  • Change the workflow name not that it also lints.
  • Run linting for all branches (except publish that only runs in main);

Docs and mic

  • Remove the Dockerfile from this repo;
  • No readme e setup “PostFinance gateway plugin for Saleor.” Devia dizer qual o metodo que suporta (payment page? etc);
  • Should the package name contain the work gateway? What do their standards say?

Copy link
Member

@tofran tofran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@guilherme1805
Copy link
Member Author

Should the package name contain the work gateway? What do their standards say?

Didn't find anything about that, found this plugin https://github.com/Qasem-h/saleor-tappayment-plugin and it doesn't have gateway in the name.

@tofran tofran merged commit 47009dd into main Sep 7, 2022
@tofran tofran deleted the develop branch September 7, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants