Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: tarot card hover effect #240

Merged
merged 12 commits into from
Sep 7, 2023
Merged

refactor: tarot card hover effect #240

merged 12 commits into from
Sep 7, 2023

Conversation

michellemeinert
Copy link
Contributor

No description provided.

@michellemeinert michellemeinert self-assigned this May 17, 2023
@pdrbrnd
Copy link
Member

pdrbrnd commented May 17, 2023

@tofran why was this not deployed?

@tofran
Copy link
Member

tofran commented May 17, 2023

@tofran why was this not deployed?

Humm idk, maybe try to update the branch first (from main). As GH is not able to due to merge conflicts.
In this tree (d11d8dc) the actions are quite old: https://github.com/significa/significa.co/tree/style/hover-tarot/.github/workflows

@github-actions github-actions bot temporarily deployed to preview May 18, 2023 08:51 Inactive
@github-actions github-actions bot temporarily deployed to preview May 18, 2023 08:54 Inactive
filipeff95
filipeff95 reviewed May 23, 2023
View reviewed changes
Copy link
Contributor

@filipeff95 filipeff95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but have you tried to make the mouse out transition smoother? Looks a bit harsh when moving the mouse away

May-23-2023.09-20-21.mp4

@pdrbrnd
Copy link
Member

pdrbrnd commented May 31, 2023

I like this but I agree with @filipeff95

not merging until we get that fixed. maybe a simple transition will suffice

@github-actions github-actions bot temporarily deployed to preview May 31, 2023 09:37 Inactive
@github-actions github-actions bot temporarily deployed to preview May 31, 2023 09:42 Inactive
@tofran
Copy link
Member

tofran commented Jul 6, 2023

@filipeff95 @pdrbrnd
Can we merge this?

cc @michellemeinert

@pdrbrnd
Copy link
Member

pdrbrnd commented Sep 7, 2023

@michellemeinert definitely! looks amazing, thanks

@pdrbrnd pdrbrnd merged commit 61981ed into main Sep 7, 2023
2 checks passed
@pdrbrnd pdrbrnd deleted the style/hover-tarot branch September 7, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdrbrnd pdrbrnd pdrbrnd approved these changes

@filipeff95 filipeff95 Awaiting requested review from filipeff95

Assignees

@michellemeinert michellemeinert

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michellemeinert @pdrbrnd @tofran @filipeff95