fix: tag former team members as such in blog #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #297 to be able to pass the CI/CD Github actions |
Fixes SIGN-584 - Add (former) to person component - Pass is_active to person as prop in blog-entry - Pass is_active to person as prop in blog-post
nunopolonia
force-pushed
the
sign-584-tag-former-teammembers
branch
from
c904f21 to
86d9981
Compare
kaaps
reviewed
Dec 18, 2023
Since the Person component is also used in the Testimonials which don't have an isActive prop, it needs to default to true otherwise the (former) tag will be shown in the testimonials
|
@kaaps While doing the changes you requested I've noticed that the Person component is also being used in the testimonials so I've set the isActive prop as true by default, otherwise all testimonials would have "(Former)" attached to them |
kaaps
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SIGN-584