feat: first naive implementation of an RSS feed #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofran
previously approved these changes
Jan 8, 2024
|
@tofran changed the PR to include the improvements you suggested. We're now getting the channel info from the blog storyblok SEO configuration. I've also removed the condition that was allowing draft posts to be shown in the rss feed if a cookie was set |
Missing better cache invalidation mechanisms
nunopolonia
force-pushed
the
sign-324-rss-feed
branch
from
a42d744 to
5c3070a
Compare
tofran
reviewed
Jan 10, 2024
tofran
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SIGN-324
First naive implementation.
I know Storyblok already handles the data caching on their side, and I added some random values to the Cache-Control headers, but I probably can change them to
no-cacheand let them be controlled by storyblok's CDN cache.If anyone has more knowledge / opinions on how to deal with this, let me know