Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow multiple authors #310

Merged
merged 1 commit into from
Jan 10, 2024
Merged

feat: allow multiple authors #310

merged 1 commit into from
Jan 10, 2024

Conversation

kaaps
Copy link
Contributor

@kaaps kaaps commented Jan 9, 2024

Screenshot 2024-01-09 at 15 23 42

@kaaps kaaps requested review from nunopolonia and tofran January 9, 2024 15:50
@kaaps kaaps self-assigned this Jan 9, 2024
Copy link

linear bot commented Jan 9, 2024

Copy link
Contributor

@nunopolonia nunopolonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have some artifacts from other PRs, specially in bloks.d.ts. My guess is that you have files open on your VS Code which are auto saving when you switch between branches. There is code in this PR related to the get a quote form, changes to the testimonial section and changes to the proposals. We should remove all the code that doesn't belong to this PR

@nunopolonia nunopolonia self-requested a review January 10, 2024 16:13
Copy link
Contributor

@nunopolonia nunopolonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talking with @kaaps, he explained me that since the files are automatically generated we ignore their output, so I'm approving it

@kaaps kaaps merged commit cbf536f into main Jan 10, 2024
2 checks passed
@kaaps kaaps deleted the SIGN-596 branch January 10, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants