Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG Fix] Page Drawer > Sometimes the page is empty #420

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

joaogomesdev
Copy link
Member

@joaogomesdev joaogomesdev commented Oct 31, 2024

Changes made in this PR

Why this is happening?

This happens because the drawer search parameter sometimes includes a duplicated parent folder (e.g., /careers/careers/internship-marketing-designer instead of /careers/internship-marketing-designer), leading to a 404 error.

Solution

To resolve this, I use the link’s href value, which ensures that the drawer always contains the correct story path.

Bug

Screen.Recording.2024-10-31.at.18.19.48.mov

@joaogomesdev joaogomesdev changed the title fix drawer search param [BUG FIx] Page Drawer > Sometimes the drawer search param is not right Oct 31, 2024
@joaogomesdev joaogomesdev changed the title [BUG FIx] Page Drawer > Sometimes the drawer search param is not right [BUG FIx] Page Drawer > Sometimes the page is empty Oct 31, 2024
@joaogomesdev joaogomesdev changed the base branch from main to page-drawer-fixed-header October 31, 2024 18:52
@joaogomesdev joaogomesdev changed the title [BUG FIx] Page Drawer > Sometimes the page is empty [BUG Fix] Page Drawer > Sometimes the page is empty Oct 31, 2024
@joaogomesdev joaogomesdev self-assigned this Oct 31, 2024
@joaogomesdev joaogomesdev merged commit 94d8f3f into page-drawer-fixed-header Nov 4, 2024
2 checks passed
@joaogomesdev joaogomesdev deleted the fix-drawer-search-param branch November 4, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant