master: merge MAG-702

signifyd · Nov 23, 2021 · 89cc34b · 89cc34b
1 parent 70db1db
commit 89cc34b
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 10 deletions.
diff --git a/Helper/PurchaseHelper.php b/Helper/PurchaseHelper.php
@@ -1000,7 +1000,7 @@ public function makeCheckoutPaymentDetailsFromQuote(Quote $quote, $methodData =
 
     public function getCardholderFromQuote(Quote $quote)
     {
-        try{
+        try {
             $firstname = $quote->getBillingAddress()->getFirstname();
             $lastname = $quote->getBillingAddress()->getLastname();
             $cardholder = trim($firstname) . ' ' . trim($lastname);

diff --git a/Plugin/Adyen/Payment/Controller/Process/Json.php b/Plugin/Adyen/Payment/Controller/Process/Json.php
@@ -87,7 +87,7 @@ public function beforeExecute(AdyenJson $subject)
         $isPreAuth = $this->purchaseHelper->getIsPreAuth($policyName, 'adyen_cc');
         $notificationItems = json_decode(file_get_contents('php://input'), true);
 
-        if ($isPreAuth === false && empty($notificationItems) === true)  {
+        if ($isPreAuth === false && empty($notificationItems) === true) {
             return null;
         }
 
@@ -98,7 +98,8 @@ public function beforeExecute(AdyenJson $subject)
             isset($notificationItems['notificationItems'][0]['NotificationRequestItem']['success']) &&
             isset($notificationItems['notificationItems'][0]['NotificationRequestItem']['reason'])
         ) {
-            $orderIncrement = $notificationItems['notificationItems'][0]['NotificationRequestItem']['merchantReference'];
+            $orderIncrement =
+                $notificationItems['notificationItems'][0]['NotificationRequestItem']['merchantReference'];
             $isSuccess = $notificationItems['notificationItems'][0]['NotificationRequestItem']['success'];
             $reason = $notificationItems['notificationItems'][0]['NotificationRequestItem']['reason'];
 
@@ -157,10 +158,13 @@ public function beforeExecute(AdyenJson $subject)
 
                 if (isset($notificationItems['notificationItems'][0]['NotificationRequestItem']['additionalData'])) {
                     $adyenData['cardLast4'] =
-                        $notificationItems['notificationItems'][0]['NotificationRequestItem']['additionalData']['cardSummary'] ?? null;
+                        $notificationItems['notificationItems'][0]
+                        ['NotificationRequestItem']['additionalData']['cardSummary'] ?? null;
 
-                    if (isset($notificationItems['notificationItems'][0]['NotificationRequestItem']['additionalData']['expiryDate'])){
-                        $expiryDate = $notificationItems['notificationItems'][0]['NotificationRequestItem']['additionalData']['expiryDate'];
+                    if (isset($notificationItems['notificationItems']
+                        [0]['NotificationRequestItem']['additionalData']['expiryDate'])) {
+                        $expiryDate = $notificationItems['notificationItems'][0]
+                            ['NotificationRequestItem']['additionalData']['expiryDate'];
                         $expiryDateArray = explode('/', $expiryDate);
                         $adyenData['cardExpiryMonth'] = $expiryDateArray[0];
                         $adyenData['cardExpiryYear'] = $expiryDateArray[1];

diff --git a/Plugin/Braintree/GeneralResponseValidator.php b/Plugin/Braintree/GeneralResponseValidator.php
@@ -89,7 +89,7 @@ public function beforeValidate($subject, array $validationSubject)
 
         $isPreAuth = $this->purchaseHelper->getIsPreAuth($policyName, 'braintree');
 
-        if ($isPreAuth === false)  {
+        if ($isPreAuth === false) {
             return null;
         }
 

diff --git a/composer.json b/composer.json
@@ -2,12 +2,12 @@
   "name": "signifyd/module-connect",
   "description": "Signifyd integration for Magento",
   "require": {
-    "signifyd/signifyd-php": "3.1.1",
+    "signifyd/signifyd-php": "3.1.2",
     "monolog/monolog": ">=1.16.0",
     "php": ">=5.5.22"
   },
   "type": "magento2-module",
-  "version": "4.3.0",
+  "version": "4.3.2",
   "autoload": {
     "files": [
       "registration.php"

diff --git a/etc/module.xml b/etc/module.xml
@@ -5,7 +5,7 @@
  */
 -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
-    <module name="Signifyd_Connect" setup_version="4.3.0">
+    <module name="Signifyd_Connect" setup_version="4.3.2">
         <sequence>
             <module name="Magento_Sales" />
             <module name="Magento_Payment" />