Skip to content

Commit

Permalink
Remove the npm test-command
Browse files Browse the repository at this point in the history
This command was added all the way back when basic CI-support was first introduced (using Travis at the time), however it's never really intended to be used e.g. for local development.
By having a `npm test`-command listed in the `package.json` file, there's a very real risk that someone unfamiliar with the code-base would only run that one and thus miss all the other (more important) test-suites[1].

Hence this patch which removes the `npm test`-command, and instead simply calls the relevant gulp-task[2] directly in the GitHub Actions configuration.

---
[1] Which consist of the unit-tests (run in browsers), the font-tests (potentially), the reference-tests, and the integration-tests.

[2] Which is also renamed slightly, to better fit its current usage.
  • Loading branch information
Snuffleupagus authored and rousek committed Aug 10, 2022
1 parent 96b3412 commit 330e6ed
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ jobs:
run: npm install

- name: Run tests
run: npm test
run: gulp ci-test
2 changes: 1 addition & 1 deletion gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -2348,7 +2348,7 @@ gulp.task("externaltest", function (done) {
});

gulp.task(
"npm-test",
"ci-test",
gulp.series(
gulp.parallel("lint", "externaltest", "unittestcli"),
"lint-chromium",
Expand Down
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,7 @@
"yargs": "^17.1.1"
},
"scripts": {
"postinstall": "cross-env PUPPETEER_PRODUCT=firefox node node_modules/puppeteer/install.js",
"test": "gulp npm-test"
"postinstall": "cross-env PUPPETEER_PRODUCT=firefox node node_modules/puppeteer/install.js"
},
"repository": {
"type": "git",
Expand Down

0 comments on commit 330e6ed

Please sign in to comment.