Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust the way of obtaining function call results #695

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

sigoden
Copy link
Owner

@sigoden sigoden commented Jul 10, 2024

Previously, AIChat collects the stdout from the function call process.

This strategy has the following drawbacks:

  • It cannot distinguish between what to print to the terminal and what to return to the LLM.
  • It does not support interactions, progression, or block actions.
  • Unnecessary dangerously_functions_filter. If the function supports interaction, it can control dangerous operations by requesting user consent.

The PR enables AIChat to obtain function call results from a file. This completely avoids the aforementioned drawbacks.

image

@sigoden sigoden merged commit 4ea6f39 into main Jul 10, 2024
3 checks passed
@sigoden sigoden deleted the feat branch July 10, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant