Remove Orchestrate from sigopt-python #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Sigopt
approved these changes
May 10, 2024
| # Copyright © 2024 Intel Corporation | ||
| # | ||
| # SPDX-License-Identifier: MIT | ||
|
|
There was a problem hiding this comment.
Why is this part of the orchestrate removal? Don't get me wrong, I think this is a useful idea, just not clear why it's part of this PR. Separate it out?
Also, why only on the log-capture feature, not on other parts of the API?
There was a problem hiding this comment.
I wanted to improve vulture's ability to catch dead code so it could find more dangling orchestrate code bits. So I removed the vulture allowlist and added this bit so it wouldn't end up on the allowlist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lacking the resources to maintain this. If revived it will move to a separate project.