Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duty services #73

Merged
merged 26 commits into from
Jan 14, 2025
Merged

Duty services #73

merged 26 commits into from
Jan 14, 2025

Conversation

dknopik
Copy link
Member

@dknopik dknopik commented Dec 13, 2024

Issue Addressed

Proposed Changes

Utilizing the newly introduced ValidatorStore trait in Lighthouse, spawn the validator_services.

Additional Info

Currently very much copy pasted to setup the client, especially the initial connection code.

Depends on #76 and #77 as well as sigp/lighthouse#6705.

@dknopik dknopik marked this pull request as ready for review January 14, 2025 12:59
@dknopik dknopik added the ready-for-review This PR is ready to be reviewed label Jan 14, 2025
Copy link
Contributor

@jking-aus jking-aus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work daniel -- lgtm

@jking-aus jking-aus merged commit 2e838d8 into sigp:unstable Jan 14, 2025
11 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants