Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSZ encodes a Hash32 with a length prefix #20

Closed
paulhauner opened this issue Sep 21, 2018 · 2 comments
Closed

SSZ encodes a Hash32 with a length prefix #20

paulhauner opened this issue Sep 21, 2018 · 2 comments

Comments

@paulhauner
Copy link
Member

s.append_encoded_val(&self.to_vec());

Presently, SSZ prefixes a Hash32 with a length prefix. It should not do this, as a Hash32 is fixed-length and does not need a length prefix.

When this is implemented, it will break the SszBlock struct. I am more than happy to fix that struct personally when the time comes.

@paulhauner
Copy link
Member Author

@NatoliChris this is probably something you'll want to consider in your SSZ works :)

paulhauner added a commit that referenced this issue Sep 21, 2018
@paulhauner
Copy link
Member Author

We should be able to close this when #16 is merged.

paulhauner pushed a commit to paulhauner/lighthouse that referenced this issue Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant