Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove internal behaviour events #3497

Merged
merged 4 commits into from
Aug 30, 2022
Merged

Remove internal behaviour events #3497

merged 4 commits into from
Aug 30, 2022

Conversation

divagant-martian
Copy link
Collaborator

@divagant-martian divagant-martian commented Aug 23, 2022 •
edited
Loading

Issue Addressed

libp2p's latest release forces a quite big refactor on our lighthouse network crate mainly because of the deprecation of the NetworkBehaviourEventProcess. While doing this, I'll need to remove InternalBehaviourMessage. This PR removes one of the variants: SocketUpdated moving acting on this event from the main Behaviour to Discovery.

Proposed Changes

simply emit the appropriate NetworkBehaviourAction from discovery directly. Event order will be slightly different (faster) but I see this as an over-all improvement

Additional Info

na

This was referenced Aug 26, 2022
Closed
Merged
@divagant-martian divagant-martian marked this pull request as ready for review August 26, 2022 20:41
@divagant-martian divagant-martian changed the base branch from unstable to libp2p-v0.47.0-upgrade August 26, 2022 20:48
@divagant-martian divagant-martian added the ready-for-review The code is ready for review label Aug 26, 2022
AgeManning
AgeManning approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Looks cleaner also.

@AgeManning AgeManning merged commit 4ad255b into sigp:libp2p-v0.47.0-upgrade Aug 30, 2022
@divagant-martian divagant-martian mentioned this pull request Sep 6, 2022
Closed
5 tasks
bors bot pushed a commit that referenced this pull request Sep 12, 2022
@divagant-martian @AgeManning
Libp2p v0.48.0 upgrade (#3547)
5ab7c9d 
## Issue Addressed

Upgrades libp2p to v.0.47.0. This is the compilation of
- [x] #3495 
- [x] #3497 
- [x] #3491 
- [x] #3546 
- [x] #3553 

Co-authored-by: Age Manning <Age@AgeManning.com>
bors bot pushed a commit that referenced this pull request Sep 29, 2022
@divagant-martian @AgeManning
Libp2p v0.48.0 upgrade (#3547)
b1d2510 
## Issue Addressed

Upgrades libp2p to v.0.47.0. This is the compilation of
- [x] #3495 
- [x] #3497 
- [x] #3491 
- [x] #3546 
- [x] #3553 

Co-authored-by: Age Manning <Age@AgeManning.com>
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@divagant-martian @AgeManning @Woodpile37
Libp2p v0.48.0 upgrade (sigp#3547)
837dbd2 
## Issue Addressed

Upgrades libp2p to v.0.47.0. This is the compilation of
- [x] sigp#3495 
- [x] sigp#3497 
- [x] sigp#3491 
- [x] sigp#3546 
- [x] sigp#3553 

Co-authored-by: Age Manning <Age@AgeManning.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgeManning AgeManning AgeManning approved these changes

@pawanjay176 pawanjay176 Awaiting requested review from pawanjay176

Assignees
No one assigned
Labels
Networking ready-for-review The code is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@divagant-martian @AgeManning