Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Release v4.1.0 #4191

Closed
wants to merge 2 commits into from

Conversation

paulhauner
Copy link
Member

@paulhauner paulhauner commented Apr 14, 2023

Issue Addressed

NA

Proposed Changes

Bump versions.

Additional Info

NA

@paulhauner paulhauner added blocked work-in-progress PR is a work-in-progress v4.1.0 Post-Capella minor release labels Apr 14, 2023
@paulhauner paulhauner force-pushed the cut-v4.1.0 branch 2 times, most recently from 01ad4c8 to d8c2f21 Compare April 18, 2023 04:36
@paulhauner
Copy link
Member Author

Current ETA for this release is 20th of April, tentative on testing.

## Issue Addressed

NA

## Proposed Changes

Avoids reprocessing loops introduced in sigp#4179. (Also somewhat related to sigp#4192).

Breaks the re-queue loop by only re-queuing when an RPC block is received before the attestation creation deadline.

I've put `proposal_is_known` behind a closure to avoid interacting with the `observed_proposers` lock unnecessarily. 

## Additional Info

NA
@paulhauner paulhauner added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Apr 20, 2023
@paulhauner paulhauner marked this pull request as ready for review April 20, 2023 00:49
@paulhauner
Copy link
Member Author

I'm happy with the results of our testing. This is ready for review and release.

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also happy with the testing, let's go! 🚀

Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@paulhauner
Copy link
Member Author

bors r+

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Apr 20, 2023
bors bot pushed a commit that referenced this pull request Apr 20, 2023
## Issue Addressed

NA

## Proposed Changes

Bump versions.

## Additional Info

NA
@bors bors bot changed the title Release v4.1.0 [Merged by Bors] - Release v4.1.0 Apr 20, 2023
@bors bors bot closed this Apr 20, 2023
xenowits pushed a commit to xenowits/lighthouse that referenced this pull request May 16, 2023
## Issue Addressed

NA

## Proposed Changes

Bump versions.

## Additional Info

NA
ghost pushed a commit to oone-world/lighthouse that referenced this pull request Jul 13, 2023
## Issue Addressed

NA

## Proposed Changes

Bump versions.

## Additional Info

NA
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
## Issue Addressed

NA

## Proposed Changes

Bump versions.

## Additional Info

NA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge. v4.1.0 Post-Capella minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants