Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - improve api-bn.md #4244

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - improve api-bn.md #4244

wants to merge 1 commit into from

Conversation

int88
Copy link
Contributor

@int88 int88 commented Apr 28, 2023

Issue Addressed

NA

Proposed Changes

improve doc api-bn.md to make user convenient to copy and run the command.

Additional Info

NA

@int88
Copy link
Contributor Author

int88 commented May 3, 2023

@michaelsproul PTAL :)

@michaelsproul
Copy link
Member

I'm in two minds about this. On the one hand it's nice to get output through jq, but on the other hand it also adds an implicit dependency on jq. Some users might not have it installed and might get confused

@int88
Copy link
Contributor Author

int88 commented May 4, 2023

I'm in two minds about this. On the one hand it's nice to get output through jq, but on the other hand it also adds an implicit dependency on jq. Some users might not have it installed and might get confused

jq is used everywhere in api-lighthouse.md, just for consistency.

BTW, the output below the command actually is the output after jq processing.

@michaelsproul
Copy link
Member

Oh right, I missed that. Let's merge then

@michaelsproul michaelsproul added docs Documentation ready-for-merge This PR is ready to merge. labels May 5, 2023
@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request May 5, 2023
@int88
improve api-bn.md (#4244)
60d13c3 
## Issue Addressed

NA

## Proposed Changes

improve doc `api-bn.md` to make user convenient to copy and run the command. 

## Additional Info

NA
@bors
Copy link

bors bot commented May 5, 2023

Pull request successfully merged into unstable.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title improve api-bn.md [Merged by Bors] - improve api-bn.md May 5, 2023
@bors bors bot closed this May 5, 2023
ghost pushed a commit to oone-world/lighthouse that referenced this pull request Jul 13, 2023
@int88
improve api-bn.md (sigp#4244)
57a63eb 
## Issue Addressed

NA

## Proposed Changes

improve doc `api-bn.md` to make user convenient to copy and run the command. 

## Additional Info

NA
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@int88 @Woodpile37
improve api-bn.md (sigp#4244)
e9676e5 
## Issue Addressed

NA

## Proposed Changes

improve doc `api-bn.md` to make user convenient to copy and run the command. 

## Additional Info

NA
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@int88 @Woodpile37
improve api-bn.md (sigp#4244)
c280d4d 
## Issue Addressed

NA

## Proposed Changes

improve doc `api-bn.md` to make user convenient to copy and run the command. 

## Additional Info

NA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Documentation ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@int88 @michaelsproul