Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testnet stability #451

Merged
merged 62 commits into from
Jul 29, 2019
Merged

Testnet stability #451

merged 62 commits into from
Jul 29, 2019

Conversation

paulhauner
Copy link
Member

Issue Addressed

NA

Proposed Changes

  • Adds the --network-dir CLI flag.
  • Simplifies the NewSlot log message, making info more useful.

Additional Info

Blocked on #449

paulhauner added 19 commits July 19, 2019 13:36
@paulhauner
Change reduced tree for adding weightless node
aa5ca51
@paulhauner
Add more comments for reduced tree fork choice
3898dcb
@paulhauner
Small refactor on reduced tree for readability
1f474ed
@paulhauner
Move test_harness forking logic into itself
d3afe25
@paulhauner
Add new AncestorIter trait to store
551e1a9
@paulhauner
Add unfinished tests to fork choice
877544c
@paulhauner
Make beacon_state.genesis_block_root public
50e2c8b
@paulhauner
Add failing lmd_ghost fork choice tests
c904559
@paulhauner
Extend fork_choice tests, create failing test
6af78db
@paulhauner
Implement Debug for generic ReducedTree
a719ecb
@paulhauner
Add lazy_static to fork choice tests
1e5033f
@paulhauner
Add verify_integrity fn to reduced tree
fb5206f
@paulhauner
Fix bugs in reduced tree
cf21ed0
@paulhauner
Ensure all reduced tree tests verify integrity
00365bc
@paulhauner
Slightly alter reduce tree test params
506d2d5
@paulhauner
Add (failing) reduced tree test
9f137ac
@paulhauner
Fix bug in fork choice
528568d 
Iter ancestors was not working well with skip slots
@paulhauner
Put maximum depth for common ancestor search
9757589 
Ensures that we don't search back past the finalized root.
@paulhauner
Add basic finalization tests for reduced tree
4a91e20
@paulhauner paulhauner self-assigned this Jul 24, 2019
@paulhauner
Change fork choice to use beacon_block_root
5928682 
Previously it was using target_root, which was wrong
michaelsproul
michaelsproul approved these changes Jul 26, 2019
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo the comments I made on the fork-choice PR being fixed

@paulhauner paulhauner added ready-for-review The code is ready for review and removed blocked labels Jul 29, 2019
@paulhauner paulhauner marked this pull request as ready for review July 29, 2019 02:10
@paulhauner paulhauner added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jul 29, 2019
@paulhauner paulhauner merged commit 177df12 into master Jul 29, 2019
@paulhauner paulhauner mentioned this pull request Jul 29, 2019
Closed
@paulhauner paulhauner deleted the testnet-stability branch July 31, 2019 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees

@paulhauner paulhauner

Labels
waiting-on-author The reviewer has suggested changes and awaits thier implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulhauner @michaelsproul