Dedup deneb delayed lookup logic #4668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into deneb-free-blobs
…into deneb-free-blobs
…into deneb-free-blobs
realbigsean
commented
Aug 25, 2023
| "block" => ?block_root, | ||
| ); | ||
| } | ||
| trace!(self.log, "Processing delayed lookup"; "block" => ?block_root, "lookup_id" => id); |
There was a problem hiding this comment.
downgraded this log and removed specific blob index information, because it ends up being outdated since this lookup as been delayed (new blobs from gossip may have arrived).
Also updated "triggering" to "processing" because at this point it's very likely we ended up just getting all block components on gossip and this lookup is no longer required
|
Thanks for looking at this jimmy, but I am going to close this in favor of #4732 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
We send a delayed lookup request to the networking layer whenever we see the first block components, as well as subsequent components until we receive all components. This de-duplicates these messages when we are sorting through them at delay expiry.
Something else we could do.. is maybe have any of these delayed lookup messages invalidated by an import?
Or maybe this could be further re-worked so that we send no messages from consensus to networking until consensus decides via it's own heuristics a block/blob is "missing". And sends a single "get me these components" message.