Fix zero port error

[ackintosh]

Issue Addressed

Fixes #5004

Proposed Changes

Changed the code to assign 0 to quic_port if tcp_port == 0.

[jmcph4]

Does this regress #4745?

[michaelsproul]

@jmcph4 I don't think we ever fully solved port-reuse, but I think this PR might make it slightly worse. We were already using unused_port::unused_udp4_port in beacon_node/src/config.rs when use_zero_ports=true.

[michaelsproul]

We also still routinely get crashes on CI due to port reuse

[jmcph4]

We also still routinely get crashes on CI due to port reuse

I was under the impression this had become a primarily Windows issue now though?

I think this PR might make it slightly worse

I agree -- more unused_*_port use will increase the rate of collisions compared to deferring to the kernel.

[ackintosh]

@jmcph4 @michaelsproul Thanks for your comments! I understand that we should use unused_*_port less to avoid the collisions on CI. I will update to assign 0 to quic_port if tcp_port == 0.

[ackintosh]

📝 I've filed #5024 to fix the check-code failure.

[AgeManning]

Looks good to me. Thanks