Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow Syncing From Genesis By Default #5031

Closed
wants to merge 2 commits into from

Conversation

ethDreamer
Copy link
Member

Issue Addressed

This is WIP. Still needs:

  • When povided the gensis sync flag, consider blocks that are from outside the prune window available if they are finalized
  • During checkpoint sync backfill, always consider blobs from prior to the provided checkpoint available regardless of whether the flag is provided

@ethDreamer ethDreamer added work-in-progress PR is a work-in-progress deneb labels Jan 3, 2024
@realbigsean
Copy link
Member

When povided the gensis sync flag, consider blocks that are from outside the prune window available if they are finalized

I think after syncing to head, we no longer want to do this, even if we used genesis sync initially

@paulhauner
Copy link
Member

I made an alternative to this over at #5038. I was originally just going to make a comment here, but I needed to code it to make sure I knew what I was talking about. We're also on a bit of a tight timeline for the Goerli Deneb release so I thought this might save some time. LMK what y'all think.

@realbigsean
Copy link
Member

Closing in favor of #5038

@realbigsean realbigsean closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deneb v4.6.0 ETA Q1 2024 work-in-progress PR is a work-in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants