Fix content type header for block v3 ssz response #5062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eserilev
changed the title
eserilev
commented
Jan 14, 2024
| @@ -4273,8 +4276,8 @@ pub fn serve<T: BeaconChainTypes>( | |||
| let (state, _execution_optimistic, _finalized) = state_id.state(&chain)?; | |||
| Response::builder() | |||
| .status(200) | |||
| .header("Content-Type", "application/ssz") | |||
There was a problem hiding this comment.
This is a lighthouse specific endpoint that was returning a Content-Type application/ssz header instead of application/octet-stream. If that was done on purpose, this change can be reverted
There was a problem hiding this comment.
I think this was just a bug! Nice catch!
There was a problem hiding this comment.
Opened an issue to delete it too, as this endpoint is v old #5063
michaelsproul
added
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Issue #5061
Proposed Changes
Fix content type header for block v3 ssz response
Also standardize the way
Content-Type application/octet-streamheader is applied